fix Mojo::Promise arguments

mojolicious · Feb 13, 2018 · 45ad9fc · 45ad9fc
1 parent c9e76b8
commit 45ad9fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/Mojo/Promise.pm b/lib/Mojo/Promise.pm
@@ -28,7 +28,7 @@ sub all {
     );
   }
 
-  return @promises ? $all : $all->resolve([]);
+  return @promises ? $all : $all->resolve;
 }
 
 sub catch { shift->then(undef, shift) }

diff --git a/t/mojo/promise.t b/t/mojo/promise.t
@@ -187,9 +187,10 @@ is_deeply \@errors, ['third'], 'promise rejected';
 
 # Empty all
 (@results, @errors) = ();
-Mojo::Promise->all()->then(sub { @results = @_ }, sub { @errors = @_ });
+Mojo::Promise->all()
+  ->then(sub { @results = 'pass', @_ }, sub { @errors = 'fail', @_ });
 Mojo::IOLoop->one_tick;
-is_deeply \@results, [[]], 'promise resolved';
+is_deeply \@results, ['pass'], 'promise resolved';
 is_deeply \@errors, [], 'promise not rejected';
 
 # Settle with promise