Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 866def2c418a
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 790425cbbd76
Choose a head ref
  • 3 commits
  • 13 files changed
  • 1 contributor

Commits on Feb 6, 2018

  1. incidentally found error in ripper while looking for something else...

    $_foo would not ever parse....
    enebo committed Feb 6, 2018
    Copy the full SHA
    d1df87a View commit details

Commits on Feb 7, 2018

  1. Yeah these symbol IDs are identifiers and so should be hard similar t…

    …o how MRI
    
    works.  We do not want them going away since we may no longer have a reference
    in the AST nor IR (actually IR does not store symbols at all but even if it did
    I would like persistence to play a future role so we can save long uncalled or
    already JITd IR to save memory).
    enebo committed Feb 7, 2018
    Copy the full SHA
    1367812 View commit details

Commits on Feb 13, 2018

  1. Still a lot of missing changes for errors but more filled in.

    const_defined? totally changed and only broken now due to missing proper logic
    for printing out type names in error messages.  Outstanding is if the string
    contains something the encoding thinks is unprintable it will display the type
    in quotes and escape the unprintable character.  dumpString is nearly correct
    but it will not correctly pick up \u0000 for \0 but instead print out \x00.
    
    Landing for now since this is again a bigish delta and it advances things a bit
    more.
    enebo committed Feb 13, 2018
    Copy the full SHA
    790425c View commit details
Loading