Keep empty sections when parsing INI #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
reviewed
Feb 13, 2018
RX14
requested changes
Feb 13, 2018
src/ini.cr
Outdated
| raise ParseException.new("unterminated section", lineno, line.size) | ||
| elsif end_idx != line.size - 1 | ||
| raise ParseException.new("data after section", lineno, end_idx + 1) | ||
| end |
There was a problem hiding this comment.
Why has this section been changed?
There was a problem hiding this comment.
I might be more efficient?
j8r
force-pushed
the
keep_empty_ini_sections
branch
2 times, most recently
from
c39150e
to
2c63e43
Compare
Sija
reviewed
Feb 13, 2018
j8r
force-pushed
the
keep_empty_ini_sections
branch
from
2c63e43
to
c2922c2
Compare
RX14
approved these changes
Feb 13, 2018
Sija
approved these changes
Feb 14, 2018
j8r
force-pushed
the
keep_empty_ini_sections
branch
from
c2922c2
to
91a025f
Compare
|
Why close @j8r? |
j8r
force-pushed
the
keep_empty_ini_sections
branch
2 times, most recently
from
101a615
to
39d8861
Compare
|
One review left before becoming mergeable |
asterite
reviewed
Apr 6, 2018
j8r
force-pushed
the
keep_empty_ini_sections
branch
2 times, most recently
from
84a5a4a
to
6174d60
Compare
Sija
reviewed
Apr 7, 2018
src/ini.cr
Outdated
| @@ -52,8 +52,7 @@ class INI | |||
| end | |||
| end | |||
|
|
|||
| ini.delete_if { |_, v| v.empty? } | |||
| ini | |||
| ini[""].empty? ? ini.reject("") : ini | |||
There was a problem hiding this comment.
Wouldn't be clearer to rewrite it as below?
ini.delete("") if ini[""].empty?
iniThere was a problem hiding this comment.
I've thinked so before, but is it better performance wise to do return ini.reject("") instead of ini.delete(""); ini ?
There was a problem hiding this comment.
No, reject will have to create a copy, whereas delete can just modify the existing one.
j8r
force-pushed
the
keep_empty_ini_sections
branch
2 times, most recently
from
23fc875
to
475aceb
Compare
Sija
reviewed
Apr 7, 2018
j8r
force-pushed
the
keep_empty_ini_sections
branch
from
475aceb
to
bd4d261
Compare
jhass
approved these changes
Apr 9, 2018
RX14
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing an INI file with only
[section]returns now{"section" => {}}instead of an empty Hash.