nginx/modules: use eustas' brotli module, google one is abandoned #34943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fork is also used by FreeBSD as of Dec 2017: https://svnweb.freebsd.org/ports?view=revision&revision=455560 See also: google/ngx_brotli#62
dtzWill
force-pushed
the
feature/ngx_brotli-eustas
branch
from
c98ae5e
to
df9ebaf
Compare
We have it use our system copy regardless, but might as well. (yes, hash does not change, since we don't fetch submodule here)
|
The current ngx_brotli is very old and has a bug that causes nginx to om nom nom memory on every request in some configurations (such as brotli+ssl+pagespeed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version works with brotli newer than Dec 2016,
optionally using system brotli instead of vendored version
(which this PR puts to good use so there's only one brotli).
@eustas is primary contributor to brotli itself[1]
so this isn't some random fork.
As mentioned in the commit, FreeBSD switched to this fork
for similar reasons Dec 2017.
[1] https://github.com/google/brotli/graphs/contributors
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)This fork is also used by FreeBSD as of Dec 2017:
https://svnweb.freebsd.org/ports?view=revision&revision=455560
See also:
google/ngx_brotli#62