Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: Don't build docs by default #34940

Merged
merged 1 commit into from Feb 13, 2018
Merged

sage: Don't build docs by default #34940

merged 1 commit into from Feb 13, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 13, 2018

This makes the HTML-docs an default-off option. Inline documentation
(matrix-plot??) is still available and HTML docs are available online.

Motivation for this change

Get below the Hydra output size limit (which I assume is 2GiB).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau
sage: Don't build docs by default
0713bde 
This makes the HTML-docs an default-off option. Inline documentation
(`matrix-plot??`) is still available and HTML docs are available online.

Motivation: Get below the Hydra output size limit.
@timokau timokau mentioned this pull request Feb 13, 2018
Closed
@7c6f434c 7c6f434c merged commit e6742ac into NixOS:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @7c6f434c @GrahamcOfBorg