Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fa798a233793
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ba92c73e2720
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 13, 2018

  1. Add modification check on String#chomp! method with default separator

    @nomadium
    nomadium committed Feb 13, 2018

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    nomadium Miguel Landaeta
    GPG key ID: AFB8E0FC9231CC6D
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    9f0bb16 View commit details

  2. Merge pull request #5041 from nomadium/raise-error-on-changes-to-froz… 

    …en-empty-string

Add modification check on String#chomp! method with default separator
    @enebo
    enebo authored Feb 13, 2018

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    nomadium Miguel Landaeta
    GPG key ID: AFB8E0FC9231CC6D
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    ba92c73 View commit details
Showing with 1 addition and 0 deletions.
  1. +1 −0 core/src/main/java/org/jruby/RubyString.java
1 change: 1 addition & 0 deletions core/src/main/java/org/jruby/RubyString.java
View file
Original file line number Diff line number Diff line change
@@ -4282,6 +4282,7 @@ public RubyString chomp19(ThreadContext context, IRubyObject arg0) {

@JRubyMethod(name = "chomp!")
public IRubyObject chomp_bang19(ThreadContext context) {
modifyCheck();
Ruby runtime = context.runtime;
if (value.getRealSize() == 0) return runtime.getNil();