Topology improvements #3190
Merged
Topology improvements #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biddisco
force-pushed
the
topology_improvements
branch
from
e7a0f70
to
3901969
Compare
The hwloc api requires a bitmap to store the numa domain in and this should not be allocated/freed every time which is an expensive operation. This adds a thread local bitmap so that queries to can reuse one each time. Making it thread local enables different tasks to query memory binding simultaneously.
biddisco
force-pushed
the
topology_improvements
branch
from
3901969
to
848dd2b
Compare
|
I just rebased this onto latest master and removed the inspect commit by squashing into another to declutter the git log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3161
Proposed Changes
Adds thread local bitmap for nodesets used when querying memory binding.