epoxy: 1.3.1 -> 1.5.0, add mesa to libepoxy runpath as fallback #35369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpletz
approved these changes
Feb 23, 2018
- libepoxy dlopen()s libEGL / libGL but didn't have mesa in its runpath -> error unless lib is already open or in LD_LIBRARY_PATH - change dependency from mesa (should be avoided) to mesa_nonglu
|
just out of curiousity: what triggered three review requests? is that intended behavior or did I do sth wrong? Edit: some of these autogenerated labels look wrong too... |
|
@xeji that's just GitHub that has issues with the automatic review requests feature in conjunction with changes base. It happens a lot, unfortunately. |
|
@GrahamcOfBorg eval |
xeji
changed the title
|
just noticed v1.3.1 was over 2.5 years old. time to update... |
|
This breaks |
|
oops... will make a fix limiting the patchelf to linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing runtime dependency: libepoxy dlopen()s libEGL / libGL but didn't have mesa in its runpath
-> error unless lib is already open or in LD_LIBRARY_PATH
change expoxy dependency from mesa (should be avoided) to mesa_noglu
Motivation for this change
libepoxy dlopen()s libs from mesa, so mesa should be in its runpath as a fallback.
This change has no effect if the lib is already open or found in LD_LIBRARY_PATH, which is the case in most applications (or else this bug would have surfaced earlier...).
But it will retrigger a number of rebuilds.
I ran across this bug when trying to run qemu built with opengl/virglrenderer support.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)