Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golint: 20160428 -> 20180208 #35375

Merged
merged 1 commit into from Feb 23, 2018
Merged

golint: 20160428 -> 20180208 #35375

merged 1 commit into from Feb 23, 2018

Conversation

carlsverre
Copy link
Contributor

@carlsverre carlsverre commented Feb 23, 2018 •
edited

Motivation for this change

Golint is very out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Feb 23, 2018

@GrahamcOfBorg build golint

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

installing
/private/tmp/nix-build-lint-20180208-e14d9b0.drv-0/go /private/tmp/nix-build-lint-20180208-e14d9b0.drv-0
/private/tmp/nix-build-lint-20180208-e14d9b0.drv-0
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7v8ldcf1ihxd5q043c13ldpj5dddsbhv-lint-20180208-e14d9b0-bin/bin
patching script interpreter paths in /nix/store/7v8ldcf1ihxd5q043c13ldpj5dddsbhv-lint-20180208-e14d9b0-bin
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/cp6icwpyp5qw6nzxdhv90524grkv457m-lint-20180208-e14d9b0
/nix/store/7v8ldcf1ihxd5q043c13ldpj5dddsbhv-lint-20180208-e14d9b0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f5g4pgmgd2hkplzv4w0vindhc8syg1a6-lint-20180208-e14d9b0-bin/bin 
patching script interpreter paths in /nix/store/f5g4pgmgd2hkplzv4w0vindhc8syg1a6-lint-20180208-e14d9b0-bin
checking for references to /tmp/nix-build-lint-20180208-e14d9b0.drv-0 in /nix/store/f5g4pgmgd2hkplzv4w0vindhc8syg1a6-lint-20180208-e14d9b0-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/6ya5r507dyhf47z08hq8hl1p8026bfhp-lint-20180208-e14d9b0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/6ya5r507dyhf47z08hq8hl1p8026bfhp-lint-20180208-e14d9b0
checking for references to /tmp/nix-build-lint-20180208-e14d9b0.drv-0 in /nix/store/6ya5r507dyhf47z08hq8hl1p8026bfhp-lint-20180208-e14d9b0...
/nix/store/f5g4pgmgd2hkplzv4w0vindhc8syg1a6-lint-20180208-e14d9b0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rzrd8fi7x0n464b63lwsp8xdy1rxnpbx-lint-20180208-e14d9b0-bin/bin
patching script interpreter paths in /nix/store/rzrd8fi7x0n464b63lwsp8xdy1rxnpbx-lint-20180208-e14d9b0-bin
checking for references to /build in /nix/store/rzrd8fi7x0n464b63lwsp8xdy1rxnpbx-lint-20180208-e14d9b0-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/qq90145s9sznrm2g6wqj50abdd172ssm-lint-20180208-e14d9b0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/qq90145s9sznrm2g6wqj50abdd172ssm-lint-20180208-e14d9b0
checking for references to /build in /nix/store/qq90145s9sznrm2g6wqj50abdd172ssm-lint-20180208-e14d9b0...
/nix/store/rzrd8fi7x0n464b63lwsp8xdy1rxnpbx-lint-20180208-e14d9b0-bin

@fpletz fpletz merged commit e38284d into NixOS:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlsverre @fpletz @GrahamcOfBorg