Skip to content

Commit 6c9e1ff

Browse files
committedMar 1, 2018
Permgen does not exist on Java 8+. [skip ci]
1 parent a42ef32 commit 6c9e1ff

File tree

4 files changed

+3
-17
lines changed

4 files changed

+3
-17
lines changed
 

Diff for: ‎core/pom.rb

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
'jruby.basedir' => '${basedir}/..',
2424
'jruby.test.memory' => '3G',
25-
'jruby.test.memory.permgen' => '2G',
2625
'jruby.compile.memory' => '2G',
2726

2827
'create.sources.jar' => false )
@@ -226,7 +225,7 @@
226225
'systemProperties' => {
227226
'jruby.home' => '${basedir}/..'
228227
},
229-
'argLine' => '-Xmx${jruby.test.memory} -XX:MaxPermSize=${jruby.test.memory.permgen} -Dfile.encoding=UTF-8 -Djava.awt.headless=true',
228+
'argLine' => '-Xmx${jruby.test.memory} -Dfile.encoding=UTF-8 -Djava.awt.headless=true',
230229
'includes' => [ 'org/jruby/test/MainTestSuite.java',
231230
'org/jruby/embed/**/*Test*.java',
232231
'org/jruby/util/**/*Test*.java',

Diff for: ‎core/pom.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ DO NOT MODIFIY - GENERATED CODE
2424
<pkg.dir>${build.dir}/pkg</pkg.dir>
2525
<spec.dir>spec</spec.dir>
2626
<maven.build.timestamp.format>yyyy-MM-dd</maven.build.timestamp.format>
27-
<jruby.test.memory.permgen>2G</jruby.test.memory.permgen>
2827
<installer.gems>${jruby.win32ole.gem}</installer.gems>
2928
<prawn.git.repo>git://github.com/sandal/prawn.git</prawn.git.repo>
3029
<version.ruby.minor>1</version.ruby.minor>
@@ -585,7 +584,7 @@ DO NOT MODIFIY - GENERATED CODE
585584
<systemProperties>
586585
<jruby.home>${basedir}/..</jruby.home>
587586
</systemProperties>
588-
<argLine>-Xmx${jruby.test.memory} -XX:MaxPermSize=${jruby.test.memory.permgen} -Dfile.encoding=UTF-8 -Djava.awt.headless=true</argLine>
587+
<argLine>-Xmx${jruby.test.memory} -Dfile.encoding=UTF-8 -Djava.awt.headless=true</argLine>
589588
<includes>
590589
<include>org/jruby/test/MainTestSuite.java</include>
591590
<include>org/jruby/embed/**/*Test*.java</include>

Diff for: ‎core/src/main/java/org/jruby/Main.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -354,11 +354,7 @@ private Status handleOutOfMemory(OutOfMemoryError ex) {
354354
boolean heapError = false;
355355

356356
if (oomeMessage != null) {
357-
if (oomeMessage.contains("PermGen")) {
358-
// report permgen memory error
359-
config.getError().println("Error: Your application exhausted PermGen area of the heap.");
360-
config.getError().println("Specify -J-XX:MaxPermSize=###M to increase it (### = PermGen size in MB).");
361-
} else if (oomeMessage.contains("unable to create new native thread")) {
357+
if (oomeMessage.contains("unable to create new native thread")) {
362358
// report thread exhaustion error
363359
config.getError().println("Error: Your application demanded too many live threads, perhaps for Fiber or Enumerator.");
364360
config.getError().println("Ensure your old Fibers and Enumerators are being cleaned up.");

Diff for: ‎maven/jruby/README.md

-8
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
11
# running tests #
22

3-
important for the rails4 warfile tests to increase the PermGen Space
4-
for jdk7
5-
6-
```
7-
export MAVEN_OPTS='-XX:MaxPermSize=512m'
8-
```
9-
10-
113
all tests from the ./maven/jruby directory
124
```
135
mvn verify -Papps

0 commit comments

Comments
 (0)
Please sign in to comment.