New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepin-icon-theme: init at 15.12.52 #36142
Conversation
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Looks like darwin has again a different opinion on filename encoding? |
@GrahamcOfBorg build deepin-icon-theme |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Looking for characters outside the ASCII range with the help of the program at #33801 (comment) and founding nothing:
|
@romildo is this maybe a bug in nix? |
@Mic92 It may be a bug in nix. But I have never used darwin, and I do not know much about it. I have learned here that the encoding of file names in darwin and in linux are no the same. That would lead to different hashes. But it does not seem to be the case here. So I do not know what is happening. |
@GrahamcOfBorg build deepin-icon-theme |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
This is probably due to case-insensitivity in the Darwin filesystem, as fetchFromGitHub normalizes the tarball... Ugh. |
@shlevy But why does it not break way more often? I have only seen this a few times. But I can imagine cases are used in many places. |
Hm, what the repo has is a lot of symlinks. |
@Mic92 the FS can be case-preserving, but not case-sensitive. For example, if you touch |
Counting the number of unique file names on linux with and without conversion to lowercase in fact does not give the same result:
|
@romildo well, my explanation actually includes a specific example — |
@7c6f434c so you are saying the repository contains case-sensitive symlinks + conventional files that result in the same location on macOS? |
It's worse — the problem is obviously about files that are different only in the case (and so become one file on MacOS), but these two aliased files are not even the same or symlinks — they have different size… |
@romildo Is the theme of any use for macOS? |
I am not a macOS user, but I suppose it is. But optional themes are a personal thing. |
@romildo so there are the following options:
I leave it up to you, what to do. |
@Mic92 |
@romildo you can use the |
@romildo but maybe it would be just easier to open a pull request. I am not sure how fast they merge though, but it looks like a trivial change to me. |
Using "systemsettings5" to explore/set icon themes, I noticed:
|
Well I thought I'd see if the "fixed" thing was resolved in latest git, but doesn't look like it. Here's what I ended up with anyway in case it's useful: dtzWill@884a92b I disabled its creation of "hicolor links" since a)it was trying to use /usr, and b)seems like wrong behavior although I could be mistaken. Patching the script to use $out instead of /usr resulted in problems generating cache for it... |
@Mic92 I have submitted a PR upstream and also patched the source in the derivation to remove the file name collision. When upstream fixes the issue we can remove the patch in the derivation. |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
It still fails on darwin. So I am giving up. Keeping only linux platform. When upstream fixes the issue, I can try again on unix platform. |
@GrahamcOfBorg build deepin-icon-theme |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
I do not use Plasma5, so I cannot explain this behaviour from |
Motivation for this change
Add deepin-icon-theme.
Here there is an image.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)