Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callCabal2nix: Fix filtering for non-cleanSourceable sources. #36141

Merged
merged 1 commit into from Feb 28, 2018
Merged

callCabal2nix: Fix filtering for non-cleanSourceable sources. #36141

merged 1 commit into from Feb 28, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Feb 28, 2018

What was here before wasn't correct anyway, and now it works in
restricted mode.

Fixes #35207

@shlevy
callCabal2nix: Fix filtering for non-cleanSourceable sources.
7f623cf 
What was here before wasn't correct anyway, and now it works in
restricted mode.

Fixes NixOS#35207
@shlevy shlevy requested a review from peti as a code owner February 28, 2018 19:24
@shlevy
Copy link
Member Author

shlevy commented Feb 28, 2018

@ElvishJerricco

@ElvishJerricco
Copy link
Contributor

@shlevy Thanks! LGTM

@shlevy shlevy merged commit 7f623cf into NixOS:master Feb 28, 2018
@shlevy shlevy deleted the callCabal2nix-restricted branch February 28, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlevy @ElvishJerricco @GrahamcOfBorg