programs/bash: install nix-bash-completions if completion is enabled #36136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables spotty nixops completion.
|
Thank you! I love being able to complete Nix commands! |
|
Do we have those enabled on the live cd? I think we should. |
|
Would be nice to do the same for zsh, I think.
|
|
Ah, ignore the previous comment.
`nixos/modules/programs/zsh/zsh.nix` already does it.
|
|
@Mic92 I agree that it would be good to turn it on for the cd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable completion for the Nix command line tools when bash completion is enabled.
The completion scripts should be pretty solid now, and I think it would be good for the user experience to install it automatically when the user have toggled
programs.bash.enableCompletion.Things done
Removed spotty nixops completion, which wasn't ready for prime time, from nix-bash-completions.
Added a note to the 18.03 changelog.
Tested VMs with
nixos-rebuild build-vmconfigured withprograms.bash.enableCompletionturned on and off.cc @bjornfor
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)