Replace hacky TT timeline code #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
force-pushed
the
nix-timeline-hacks
branch
3 times, most recently
from
d2be552
to
e08f42b
Compare
yvanzo
requested changes
Mar 19, 2018
|
@yvanzo which version of FF? They are displayed for me in 52.7.2 ESR and 60.0b4. 🤔 |
yvanzo
approved these changes
Mar 28, 2018
yvanzo
approved these changes
Mar 28, 2018
Return JSON directly and process it on the client to avoid unnecessary work on the server.
Removes a point where data had to be passed from the Perl to the JS. Allows us to remove an inline script tag with hacky TT code generation.
mwiencek
force-pushed
the
nix-timeline-hacks
branch
from
e08f42b
to
fe0867a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using some very wacky TT to generate JavaScript code for the client. This replaces all of that with actual JavaScript. The dynamic bits are fetched via ajax and constructed on the client.