Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Libreoffice 6 (works, but I don't like one test I disabled) #36149

Merged
merged 1 commit into from Mar 1, 2018
Merged

[WIP] Libreoffice 6 (works, but I don't like one test I disabled) #36149

merged 1 commit into from Mar 1, 2018

Conversation

7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Mar 1, 2018 •
edited

Motivation for this change

LibreOffice Fresh 6.0.1.1

Why not a direct push?

  • Maybe I will clean up some rendering tests — I have improved the font handling, now it works nope, rendering tests also fail for reasons other than fonts
  • I have disabled a test that seems to be about data correctness and not about rendering. Any feedback?

See #36111 for the progress log and links about the test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (actually, not exactly, but doesn't matter)
    • (N/A) macOS — unsupported platform
    • other Linux distributions
  • (N/A): Not tested via NixOS test(s) — none applicable
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c self-assigned this Mar 1, 2018
@7c6f434c 7c6f434c requested a review from abbradar March 1, 2018 00:19
@7c6f434c 7c6f434c added this to the 18.03 milestone Mar 1, 2018
@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 1, 2018

I don't know how to fix the new test, so this PR is approaching being self-merged.

@7c6f434c 7c6f434c closed this Mar 1, 2018
@7c6f434c 7c6f434c merged commit f6de73b into NixOS:master Mar 1, 2018
@7c6f434c
libreoffice-fresh: 5.4.1.2 -> 6.0.1.1
f6de73b 
One of the newly disabled tests is not a pure rendering test and might
be related to data consistency (unfortunately)
@abbradar
Copy link
Member

abbradar commented Mar 1, 2018 via email

@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 1, 2018

Well, it seems related to a specific way of importing data from an external file. And the bug has probably been in LO for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees

@7c6f434c 7c6f434c

Labels
8.has: package (update) 9.needs: community feedback 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: nixpkgs-member 11.by: package-maintainer
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@7c6f434c @abbradar @GrahamcOfBorg