Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9b509588b66a^
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 75ac955e7074
Choose a head ref
  • 2 commits
  • 69 files changed
  • 1 contributor

Commits on Mar 1, 2018

  1. Make better use of context-cached "immediates". 

    This commit is a global search and replace of all code that
traverses through context.runtime to get at nil, true, and false
objects rather than using the cached versions on context itself.
The context is thread-local and probably very likely to be in the
CPU cache, which means these references should be in cache also.
    @headius
    headius committed Mar 1, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    headius Charles Oliver Nutter
    GPG key ID: 8E26FF248BC7AEAD
    Verified
    Learn about vigilant mode
    Copy the full SHA
    9b50958 View commit details

  2. Retype these cache fields to provide better type information. 

    I do not know if a JVM can do this, but knowing that the fields
on ThreadContext are final, and you're always accessing e.g.
context.tru, and context.tru is always truthy, there may be cases
that can fold away. Maybe. In any case, this found a bug in
RubyGlobal where an object that could never be nil was being
compared to nil.
    @headius
    headius committed Mar 1, 2018
    Copy the full SHA
    75ac955 View commit details
Loading