Better use of ThreadContext constants #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Correction: the |
headius
force-pushed
the
better_context_constants
branch
from
75ac955
to
9b50958
Compare
kares
approved these changes
Mar 1, 2018
enebo
approved these changes
Mar 1, 2018
This commit is a global search and replace of all code that traverses through context.runtime to get at nil, true, and false objects rather than using the cached versions on context itself. The context is thread-local and probably very likely to be in the CPU cache, which means these references should be in cache also.
headius
force-pushed
the
better_context_constants
branch
from
9b50958
to
6bb18b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes here:
context.runtime.getTrue()for true, false, and nil and replacing them with thecontext.trupattern.Retyping thetru,fals, andnilfields on ThreadContext to be the most specific type.The latter change is binary incompatible if any third-party libraries have started to use these fields directly. However these fields were introduced fairly recently.The second change has been removed because of additional internal compatibility problems. There are many places in code generation, and likely in any AOT code in the wild, that try to access the
nilfield usingIRubyObject.