papis: 0.5.2 -> 0.5.3 #35252

nico202 · 2018-02-20T22:55:42Z

Motivation for this change

Fixed tests as pointed out in papis/papis#58

dotlambda

This seems fine so far.
However, looking at https://travis-ci.org/papis/papis/jobs/344071736, I see that we're only running 11/35 tests.
Maybe you could specify

checkPhase = ''
  make test
  make test-non-pythonic
'';

But then, we'd need to package https://pypi.org/project/dmenu/ and at least add pytest to checkInputs: https://github.com/papis/papis/blob/master/setup.py#L87

nico202 · 2018-02-20T23:43:34Z

@dotlambda done, but there's a failing test on my machine

adisbladis · 2018-02-21T01:48:46Z

@GrahamcOfBorg build papis

GrahamcOfBorg · 2018-02-21T01:49:01Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘python3.6-construct-2.8.16’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/python-modules/construct/default.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-21T01:49:19Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

DEBUG:downloaders:aps:[bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
DEBUG:downloaders:aps:[bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
------------------------------ Captured log call -------------------------------
base.py                     20 DEBUG    [url] = http://journals.aps.org/prb/abstract/10.1103/PhysRevB.95.085434
aps.py                      55 DEBUG    [bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
aps.py                      55 DEBUG    [bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
===================== 1 failed, 34 passed in 3.90 seconds ======================
make: *** [Makefile:302: test] Error 1
builder for ‘/nix/store/qwmsr4r6slp6hiv0r1zp9l5lmvllwcq5-papis-0.5.3.drv’ failed with exit code 2
error: build of ‘/nix/store/qwmsr4r6slp6hiv0r1zp9l5lmvllwcq5-papis-0.5.3.drv’ failed

GrahamcOfBorg · 2018-02-21T01:50:10Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

DEBUG:downloaders:aps:[bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
DEBUG:downloaders:aps:[bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
------------------------------ Captured log call -------------------------------
base.py                     20 DEBUG    [url] = http://journals.aps.org/prb/abstract/10.1103/PhysRevB.95.085434
aps.py                      55 DEBUG    [bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
aps.py                      55 DEBUG    [bibtex url] = http://journals.aps.org/prb/export/10.1103/PhysRevB.95.085434?type=bibtex&download=true
===================== 1 failed, 34 passed in 24.74 seconds =====================
make: *** [Makefile:302: test] Error 1
builder for '/nix/store/c6sivp9r4xyqshbqf4h2a79b1sqz65i2-papis-0.5.3.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/c6sivp9r4xyqshbqf4h2a79b1sqz65i2-papis-0.5.3.drv' failed

adisbladis · 2018-02-21T02:02:29Z

pkgs/tools/misc/papis/default.nix

 , vim
 }:

 buildPythonApplication rec {
  pname = "papis";
-  version = "0.5.2";
+  version = "0.5.3";

  # Missing tests on Pypi
  src = fetchFromGitHub {
    owner = "alejandrogallo";


Github redirects from https://github.com/alejandrogallo/papis to https://github.com/papis/papis so this should be updated.

adisbladis · 2018-02-21T02:16:55Z

@nico202 This is because that test is attempting to use networking (which is not available in the build environment).

You can skip that test.

dotlambda

Please squash the last two commits and name them something like papis: fix tests

nico202 · 2018-02-21T11:26:44Z

I'll squash everything as soon as it starts working. I can't figure out the problem now

edit: found the problem, but don't know what was causing it. Also, the fixes are ugly

dotlambda · 2018-02-21T12:35:16Z

pkgs/tools/misc/papis/default.nix

    mkdir -p check-phase
+    patchShebangs tests
+    sed -i "s|^papis |$out/bin/papis |" tests/bash/test_default.sh
+    sed -i "s|papis |$out/bin/papis |" tests/bash/test_help.sh


You can probably do this with

export PATH=$out/bin:$PATH

better thanks

dotlambda · 2018-02-21T12:40:17Z

pkgs/tools/misc/papis/default.nix

+    # Still don't know why this fails
+    sed -i 's/--set dir=hello //' tests/bash/test_default.sh
+
+    sed -i 's/test_downloader_getter(self):/disabled_test_downloader_getter(self):/' papis/downloaders/tests/test_main.py


Add a comment that this tests requires a network connection

dotlambda · 2018-02-21T12:40:54Z

pkgs/tools/misc/papis/default.nix

    mkdir -p check-phase
+    patchShebangs tests


This belongs into pre/postPatch

dotlambda · 2018-02-21T13:22:36Z

pkgs/tools/misc/papis/default.nix

-  postPatch = "sed -i 's/configparser>=3.0.0/# configparser>=3.0.0/' setup.py";
+  postPatch = ''
+      sed -i 's/configparser>=3.0.0/# configparser>=3.0.0/' setup.py
+      patchShebangs tests


indentation

dotlambda · 2018-02-21T13:23:31Z

I'll look at the --set dir=hello thing later today.

dotlambda · 2018-02-21T16:37:58Z

pkgs/tools/misc/papis/default.nix

    export HOME=$(pwd)/check-phase
+    make test
+    make test-non-pythonic


SH=${bashInteractive}/bin/bash make test-non-pythonic should solve the problem.

nico202 · 2018-02-21T20:10:29Z

@dotlambda thanks a lot, it seems to be ok now

dotlambda · 2018-02-21T22:48:59Z

@GrahamcOfBorg build papis

GrahamcOfBorg · 2018-02-21T22:50:17Z

Success on x86_64-linux (full log)

Partial log (click to expand)

  --rofi      Rofi based UI
  --urwid     Urwid based UI
  --vim       Vim based UI
sync
usage: papis sync [-h]

optional arguments:
  -h, --help  show this help message and exit
zotero/test_zotero.sh
/nix/store/paaqyfv1n7csbz4dcn3dp2n0pljm32iv-papis-0.5.3

dotlambda

Thanks a lot!

GrahamcOfBorg · 2018-02-21T22:52:44Z

Success on aarch64-linux (full log)

Partial log (click to expand)

  --rofi      Rofi based UI
  --urwid     Urwid based UI
  --vim       Vim based UI
sync
usage: papis sync [-h]

optional arguments:
  -h, --help  show this help message and exit
zotero/test_zotero.sh
/nix/store/qk0klmqr2jn71yk2yi9gig08mjlpphw9-papis-0.5.3

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 20, 2018

dotlambda reviewed Feb 20, 2018

View reviewed changes

nico202 added 2 commits February 21, 2018 00:42

dmenu-python: init at 0.2.1

7c14e8b

papis: 0.5.2 -> 0.5.3

43860cc

nico202 force-pushed the master branch from 14fecbe to 43860cc Compare February 20, 2018 23:42

nico202 requested a review from FRidh as a code owner February 20, 2018 23:42

GrahamcOfBorg added 6.topic: python 8.has: package (new) labels Feb 20, 2018

adisbladis reviewed Feb 21, 2018

View reviewed changes

dotlambda approved these changes Feb 21, 2018

View reviewed changes

nico202 force-pushed the master branch from 2a1bad0 to c87ff0a Compare February 21, 2018 11:32

dotlambda requested changes Feb 21, 2018

View reviewed changes

nico202 force-pushed the master branch 2 times, most recently from 0e2cdf9 to 9bf261f Compare February 21, 2018 12:44

dotlambda reviewed Feb 21, 2018

View reviewed changes

nico202 force-pushed the master branch from 9bf261f to fe6665a Compare February 21, 2018 13:26

dotlambda reviewed Feb 21, 2018

View reviewed changes

papis: fix tests

00c5907

nico202 force-pushed the master branch from fe6665a to 00c5907 Compare February 21, 2018 20:09

dotlambda approved these changes Feb 21, 2018

View reviewed changes

FRidh merged commit 383da0f into NixOS:master Feb 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

papis: 0.5.2 -> 0.5.3 #35252

papis: 0.5.2 -> 0.5.3 #35252

nico202 commented Feb 20, 2018 •

edited

dotlambda left a comment •

edited

nico202 commented Feb 20, 2018

adisbladis commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

adisbladis Feb 21, 2018

adisbladis commented Feb 21, 2018

dotlambda left a comment

nico202 commented Feb 21, 2018 •

edited

dotlambda Feb 21, 2018

nico202 Feb 21, 2018

dotlambda Feb 21, 2018

dotlambda Feb 21, 2018

dotlambda Feb 21, 2018

dotlambda commented Feb 21, 2018

dotlambda Feb 21, 2018

nico202 commented Feb 21, 2018

dotlambda commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

dotlambda left a comment

GrahamcOfBorg commented Feb 21, 2018

papis: 0.5.2 -> 0.5.3 #35252

papis: 0.5.2 -> 0.5.3 #35252

Conversation

nico202 commented Feb 20, 2018 • edited

Motivation for this change

dotlambda left a comment • edited

Choose a reason for hiding this comment

nico202 commented Feb 20, 2018

adisbladis commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

adisbladis Feb 21, 2018

Choose a reason for hiding this comment

adisbladis commented Feb 21, 2018

dotlambda left a comment

Choose a reason for hiding this comment

nico202 commented Feb 21, 2018 • edited

dotlambda Feb 21, 2018

Choose a reason for hiding this comment

nico202 Feb 21, 2018

Choose a reason for hiding this comment

dotlambda Feb 21, 2018

Choose a reason for hiding this comment

dotlambda Feb 21, 2018

Choose a reason for hiding this comment

dotlambda Feb 21, 2018

Choose a reason for hiding this comment

dotlambda commented Feb 21, 2018

dotlambda Feb 21, 2018

Choose a reason for hiding this comment

nico202 commented Feb 21, 2018

dotlambda commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

dotlambda left a comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Feb 21, 2018

nico202 commented Feb 20, 2018 •

edited

dotlambda left a comment •

edited

nico202 commented Feb 21, 2018 •

edited