Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcal: init at 1.7 #35230

Merged
merged 1 commit into from Feb 20, 2018
Merged

bcal: init at 1.7 #35230

merged 1 commit into from Feb 20, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

This is a nice and simple tool for calculating storage addresses and more.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jfrankenau referenced this pull request Feb 20, 2018
@jfrankenau
nnn: 1.3 -> 1.5
6248220
@joachifm
Copy link
Contributor

@GrahamcOfBorg build bcal

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash
gcc -O3 -m64 -Wall -Wextra -Wno-unused-parameter -Werror -Iinc -o bcal src/log.c src/bcal.c -lquadmath
gcc: error: unrecognized command line option '-m64'
make: *** [Makefile:14: bcal] Error 1
builder for '/nix/store/s7sndyxciyg3j1w12jy9y8nsc9q12aal-bcal-1.7.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/s7sndyxciyg3j1w12jy9y8nsc9q12aal-bcal-1.7.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash
gcc -O3 -m64 -Wall -Wextra -Wno-unused-parameter -Werror -Iinc -o bcal src/bcal.c src/log.c -lquadmath
/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash: gcc: command not found
make: *** [Makefile:14: bcal] Error 127
builder for '/nix/store/ls0rk5m5vw7hanyidfr52dax3h713k3d-bcal-1.7.drv' failed with exit code 2
error: build of '/nix/store/ls0rk5m5vw7hanyidfr52dax3h713k3d-bcal-1.7.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

rm -f bcal.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6kn7m607y54w74jpgdc3k6qzb1wwv04g-bcal-1.7
shrinking /nix/store/6kn7m607y54w74jpgdc3k6qzb1wwv04g-bcal-1.7/bin/bcal
gzipping man pages under /nix/store/6kn7m607y54w74jpgdc3k6qzb1wwv04g-bcal-1.7/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/6kn7m607y54w74jpgdc3k6qzb1wwv04g-bcal-1.7/bin
patching script interpreter paths in /nix/store/6kn7m607y54w74jpgdc3k6qzb1wwv04g-bcal-1.7
checking for references to /build in /nix/store/6kn7m607y54w74jpgdc3k6qzb1wwv04g-bcal-1.7...
/nix/store/6kn7m607y54w74jpgdc3k6qzb1wwv04g-bcal-1.7

Mic92
Mic92 reviewed Feb 20, 2018
View reviewed changes
pkgs/applications/science/math/bcal/default.nix Outdated
python3 -m pytest test.py
'';

installFlags = [ "DESTDIR=$(out)" "PREFIX=" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeFlags = [ "CC=cc" ]; hopefully fixes darwin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jarun/bcal/blob/master/Makefile#L1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you. Let's see if this works. Additionally, If I'm not mistaken the -m64 flag leaves us only with x86_64 systems which is why aarch64 fails. How would I best go on with specifiying this in the meta section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

["x86_64-darwin" "x86_64-linux" ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But actually -m64 should be skipped on aarch64. This could be fixed upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jarun/bcal#17

@jfrankenau jfrankenau force-pushed the init-bcal branch 2 times, most recently from ca8f0d4 to e839988 Compare February 20, 2018 23:04
@Mic92 Mic92 mentioned this pull request Feb 20, 2018
Closed
@Mic92 Mic92 merged commit 03e7929 into NixOS:master Feb 20, 2018
@jfrankenau jfrankenau deleted the init-bcal branch February 20, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jfrankenau @joachifm @GrahamcOfBorg @Mic92