Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgis: get rid of composableDerivation #35243

Merged
merged 1 commit into from Feb 22, 2018
Merged

postgis: get rid of composableDerivation #35243

merged 1 commit into from Feb 22, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Feb 20, 2018

In this change composableDerivation is removed in favor of
stdenv.mkDerivation.

Motivation for this change

#18763

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
postgis: get rid of composableDerivation
b2f53c7 
In this change composableDerivation is removed in favor of
stdenv.mkDerivation.
@FRidh
Copy link
Member Author

FRidh commented Feb 20, 2018

Note the only difference between default.nix and 2_3.nix is the version and the hash so we could just use an override.

Also, we should update to the latest patch release.

@FRidh FRidh added this to the 18.03 milestone Feb 20, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/lib/postgis-2.4.so
shrinking /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/lib/rtpostgis-2.4.so
shrinking /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/lib/postgis_topology-2.4.so
shrinking /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/bin/raster2pgsql
shrinking /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/bin/pgsql2shp
shrinking /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/bin/shp2pgsql
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/lib  /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0/bin
patching script interpreter paths in /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0
checking for references to /build in /nix/store/3jxdls03dzccl1l3q7gwnlw44gnkjxr6-postgis-2.4.0...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘postgis-2.4.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/postgis/default.nix:96 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

/build/hdf-4.2.12/hdf/src/vgp.c:3482:13: error: unknown type name 'uint16'
             uint16 *refarray /* IN/OUT: ref array to fill */)
             ^~~~~~
make[2]: *** [hdf/src/CMakeFiles/hdf-shared.dir/build.make:1263: hdf/src/CMakeFiles/hdf-shared.dir/vgp.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:984: hdf/src/CMakeFiles/hdf-shared.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/aamszlnixdnhnls4ac28jkmvzq2q69mf-hdf-4.2.12.drv' failed with exit code 2
cannot build derivation '/nix/store/rx51xx9c7wa5p9yimkxmg2lhgxgpa9x1-gdal-2.2.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/900zi85pgixsrk7mxcb8kaa4lzd4c8p4-postgis-2.4.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/900zi85pgixsrk7mxcb8kaa4lzd4c8p4-postgis-2.4.0.drv' failed

@FRidh FRidh merged commit d328ba7 into NixOS:master Feb 22, 2018
@FRidh FRidh deleted the postgis branch February 22, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @GrahamcOfBorg