Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 4e44025ac5e2
Choose a base ref
...
head repository: NixOS/nix
compare: 7c377dc5cc28
Choose a head ref
  • 4 commits
  • 5 files changed
  • 2 contributors

Commits on Feb 19, 2018

  1. libutil: Fix infinite loop in filterANSIEscapes on '\r'

    E.g. nix-instantiate --eval -E 'abort "\r"' hangs.
    
    Found by afl-fuzz.
    dezgeg committed Feb 19, 2018
    Copy the full SHA
    1d0e428 View commit details
    Browse the repository at this point in the history
  2. libexpr: Fix prim_replaceStrings() to work on an empty source string

    Otherwise, running e.g.
    
    nix-instantiate --eval -E --strict 'builtins.replaceStrings [""] ["X"] "abc"'
    
    would just hang in an infinite loop.
    
    Found by afl-fuzz.
    dezgeg committed Feb 19, 2018
    Copy the full SHA
    4ea9707 View commit details
    Browse the repository at this point in the history
  3. libutil: Fix invalid assert on decoding base64 hashes

    The assertion is broken because there is no one-to-one mapping from
    length of a base64 string to the length of the output.
    
    E.g.
    
    "1q69lz7Empb06nzfkj651413n9icx0njmyr3xzq1j9q=" results in a 32-byte output.
    "1q69lz7Empb06nzfkj651413n9icx0njmyr3xzq1j9qy" results in a 33-byte output.
    
    To reproduce, evaluate:
    
    builtins.derivationStrict {
        name = "0";
        builder = "0";
        system = "0";
        outputHashAlgo = "sha256";
        outputHash = "1q69lz7Empb06nzfkj651413n9icx0njmyr3xzq1j9qy";
    }
    
    Found by afl-fuzz.
    dezgeg committed Feb 19, 2018
    Copy the full SHA
    546f98d View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. Copy the full SHA
    7c377dc View commit details
    Browse the repository at this point in the history