Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brscan4 module: Added to modules-list.nix. #35256

Merged
merged 1 commit into from Feb 21, 2018
Merged

brscan4 module: Added to modules-list.nix. #35256

merged 1 commit into from Feb 21, 2018

Conversation

jraygauthier
Copy link
Member

As requested by multiples users in #20632.

Motivation for this change

Request by users in #20632.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Would be a good addition for nixos stable branch.

@jraygauthier
brscan4 module: Added to modules-list.nix.
de1d486 
As requested by multiples users in NixOS#20632.
@Mic92 Mic92 merged commit 463b220 into NixOS:master Feb 21, 2018
@Mic92
Copy link
Member

Mic92 commented Feb 21, 2018

backported in de1d486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jraygauthier @Mic92 @GrahamcOfBorg