Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mysql: Unbreak initial database creation #35241

Merged
merged 1 commit into from Feb 24, 2018
Merged

nixos/mysql: Unbreak initial database creation #35241

merged 1 commit into from Feb 24, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Feb 20, 2018 •
edited

Motivation for this change

Unbreaks the initial database creation and thus the mysql test.
#33821 broke it since "`testdb`" gets substituted by bash, leading to command not found.

Things done

Use single quotes around the mysql quotations.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Feb 20, 2018

@GrahamcOfBorg test mysql

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

master: exit status 1
syncing
master: running command: sync
master: exit status 0
test script finished in 33.83s
cleaning up
killing master (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/q7aq5jl13mzls905a1w86rrq0719j7aw-vm-test-run-mysql

@srhb
Copy link
Contributor Author

srhb commented Feb 20, 2018 •
edited

@yurrriq Does this look right to you? I've little experience with mysql. The final strings should now be the literals

create database `testdb`;

and

use `testdb`;

@srhb srhb mentioned this pull request Feb 20, 2018
Merged
8 tasks
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

building '/nix/store/jf24klfr7nslnc9zg8ia2y5fw54idqkf-unit-mysql.service.drv'...
cannot build derivation '/nix/store/xmjh9dhnb572ww7p8k4agbl9jw26krn4-system-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/3yplwj241qczx8pjaf9pj5zqq2j61nbk-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/qgk765q7vnxwznrhwpa1k9pz00q6qkbp-nixos-system-master--18.03.git.0b39373.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/d10lda88pcmjmbapmn6vcf1vldil09zf-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/a1fzy7c00wa68b7pw82flry640h3fh6a-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/020jikj8ky7fx4959w9zipinylvmzg50-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bzdqqkw7s43bram2a3ck2lsq2rj3w38x-nixos-test-driver-mysql.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jjpx3qrx6fflf5f53kgiixjggrx6nmw8-vm-test-run-mysql.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/jjpx3qrx6fflf5f53kgiixjggrx6nmw8-vm-test-run-mysql.drv' failed

@srhb
Copy link
Contributor Author

srhb commented Feb 24, 2018

@Profpatsch Looks like you reviewed the last one, could you sanity check this, please? :)

@Profpatsch
Copy link
Member

Profpatsch commented Feb 24, 2018 •
edited

I still don’t have any experience with mysql syntax, but if the test goes through, I’m all for it.

builder for '/nix/store/wm0nmz9xm47f5k215cy3c1crpih82gps-strace-4.21.drv' failed with exit code 1

It looks like strace is broken on master. :(
Edit: was, apparently.

@Profpatsch
Copy link
Member

@GrahamcOfBorg test mysql mysqlBackup mysqlReplication

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

test script finished in 48.20s
cleaning up
killing slave2 (pid 623)
killing slave1 (pid 612)
killing master (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-mysql-replication.drv-0/vde1.ctl': Directory not empty
/nix/store/6r9wfb9mzqvm74b2gjwpbwgdr1qyv689-vm-test-run-mysql
/nix/store/4nicb73v7f6cypmmq4kgv383hhg64804-vm-test-run-mysql-backup
/nix/store/586w6fkz4fb983mjl9h1n78qjzid8nx8-vm-test-run-mysql-replication

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

test script finished in 51.80s
cleaning up
killing slave1 (pid 649)
killing master (pid 627)
killing slave2 (pid 661)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/42kiivk3la7g3871rvvxkblyajjkv29f-vm-test-run-mysql
/nix/store/021sgvxvxbna4pdd17yyd30f5pjvlvf4-vm-test-run-mysql-backup
/nix/store/hp9bhwp9gqfynagqlg45fwnb2a95l60g-vm-test-run-mysql-replication

@Profpatsch
Copy link
Member

@GrahamcOfBorg test mysql mysqlBackup

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

syncing
master: running command: sync
master: exit status 0
test script finished in 41.33s
cleaning up
killing master (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-mysql.drv-0/vde1.ctl': Directory not empty
/nix/store/5xjjbnavs60m0q59a1samr8lf9spajni-vm-test-run-mysql
/nix/store/5g75y9jcmlx97d025683hygs1f4y06kr-vm-test-run-mysql-backup

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

syncing
master: running command: sync
master: exit status 0
test script finished in 33.87s
cleaning up
killing master (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/lvhgsmspmxi06f024xqa7h1cmvjfiah5-vm-test-run-mysql
/nix/store/xzjnhai33rkkc2axxhrf9xls9rp8rfw2-vm-test-run-mysql-backup

@Profpatsch
Copy link
Member

Profpatsch commented Feb 24, 2018 •
edited

Ah, it builds all three tests in one go, my bad.
Let’s get this merged, then.

@Profpatsch Profpatsch merged commit 2ea8f8a into NixOS:master Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @GrahamcOfBorg @Profpatsch