Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strace: disable mpers (multiple personality) support on aarch64 to fix #35236

Closed
wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 20, 2018

This fixes the build on aarch64, but may limit functionality in the long-term
that would be hidden by avoiding an underlying problem.

Or maybe this is best.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Feb 20, 2018

Hmm. I'll give this a try and try either this or revert, whichever is better.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/z7k4qnrvab9l08aynamhwq27m36g23hz-strace-4.21

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘strace-4.21’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/misc/strace/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/lscmjgcp9g7s44wras5vjn3bp76vp768-strace-4.21

@dtzWill
Copy link
Member Author

dtzWill commented Feb 20, 2018

Hmm. I'll give this a try and try either this or revert, whichever is better.

Not sure I follow, but are you saying you'll take things from here? :)

@dezgeg
Copy link
Contributor

dezgeg commented Feb 21, 2018

Not sure I follow, but are you saying you'll take things from here? :)

Yep. :)

I googled around a bit and basically I think it's an upstream bug that the build fails fatally (by default) when it finds out that -m32 doesn't work on AArch64, given that GCC doesn't support such a flag there (and I expect they never will). So I hope this can be removed one day in a further upstream release.

I did do s/=no/=check/
to make it a bit more futureproof (i.e. in case strace grows support for -milp32 on AArch64 one day, we don't want to unconditionally disable it): 8989a6b

@dezgeg dezgeg closed this Feb 21, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Feb 21, 2018

Perfect, I wasn't thrilled about the "=no" bit myself, check (assuming it does what it sounds, how is this not the default??) sounds great.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants