pulseaudio-dlna #35245

mogorman · 2018-02-20T22:06:18Z

Motivation for this change

Resolves #35231

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-02-20T22:10:18Z

pkgs/top-level/python-packages.nix

@@ -11319,6 +11319,38 @@ in {
    };
  });

+  notify2 = buildPythonPackage rec  {


Please add this to a dedicated file in python-modules and add a reference here with callPackages as described in the header of this file.

Mic92 · 2018-02-20T22:10:54Z

pkgs/top-level/python-packages.nix

+
+    doCheck = false;        # Requires real X session to run tests
+
+    src = pkgs.fetchurl {


fetchPypi is preferred here.

Mic92 · 2018-02-20T22:11:30Z

pkgs/top-level/python-packages.nix

@@ -11319,6 +11319,38 @@ in {
    };
  });

+  notify2 = buildPythonPackage rec  {
+    pname = "notify2";
+    name = "${pname}-${version}";


this the default for buildPythonPackage if pname and version is set.

dotlambda · 2018-02-20T22:08:36Z

pkgs/applications/audio/pulseaudio-dlna/default.nix

+{ fetchFromGitHub, stdenv, pythonPackages, lame, opusTools, faac, flac, sox, vorbisTools }:
+
+pythonPackages.buildPythonApplication rec {
+  name = "pulseaudio-dlna";


dotlambda · 2018-02-20T22:10:13Z

pkgs/applications/audio/pulseaudio-dlna/default.nix

+
+pythonPackages.buildPythonApplication rec {
+  name = "pulseaudio-dlna";
+  version = "2017-11-01";


Why not 0.5.2? If you want a development snapshot, you can simply override the version.

I did the latest as the author has not released in a long time.

As the project uses a couple python libraries this seems appropriate to not roadblock other projects, when updating python libraries.

dotlambda · 2018-02-20T22:12:08Z

pkgs/applications/audio/pulseaudio-dlna/default.nix

+    "sha256" = "1dfn7036vrq49kxv4an7rayypnm5dlawsf02pfsldw877hzdamqk";
+  };
+
+  propagatedBuildInputs = with pythonPackages; [ dbus-python docopt requests setproctitle protobuf psutil futures chardet notify2 netifaces pyroute2 lxml zeroconf ] ++ [ lame opusTools faac flac sox vorbisTools ];


Please split into multiple lines.

Mic92 · 2018-02-20T22:13:27Z

pkgs/top-level/python-packages.nix

+#    ];
+#
+#
+    propagatedBuildInputs = [ self.pygobject3 self.dbus-python pkgs.gtk3 pkgs.gobjectIntrospection ];


Are you sure about gtk3 in propagedBuildInputs? It looks like it only uses Python libraries and gtk3 does not contain any.

I couldn't get it to build without it but I am not positive it is needed. I will do more testing now.

Mic92 · 2018-02-20T22:14:00Z

pkgs/applications/audio/pulseaudio-dlna/default.nix

+    owner = "masmu";
+    repo = "pulseaudio-dlna";
+    "rev" = "4472928dd23f274193f14289f59daec411023ab0";
+    "sha256" = "1dfn7036vrq49kxv4an7rayypnm5dlawsf02pfsldw877hzdamqk";


rev without "; same for sha256.

mogorman · 2018-02-21T04:15:08Z

made the changes you requested @Mic92

mogorman · 2018-02-21T04:17:47Z

@Mic92 rolling back the version issue we discussed, as the 0.5.2 version does not correctly connect to the pulseaudio daemon in 17.09 otherwise. I did email the author about possibly cutting a newer release though.

FRidh · 2018-02-21T08:31:24Z

pkgs/applications/audio/pulseaudio-dlna/default.nix

+    sha256 = "1dfn7036vrq49kxv4an7rayypnm5dlawsf02pfsldw877hzdamqk";
+  };
+
+  propagatedBuildInputs = with pythonPackages; [ dbus-python docopt


maybe a newline instead of all this white space?

dotlambda · 2018-02-21T08:36:31Z

pkgs/applications/audio/pulseaudio-dlna/default.nix

+    description = "A lightweight streaming server which brings DLNA / UPNP and Chromecast support to PulseAudio and Linux";
+    homepage = https://github.com/masmu/pulseaudio-dlna;
+
+    license = stdenv.lib.licenses.gpl3Plus;


no stdenv.lib

dotlambda · 2018-02-21T08:40:48Z

pkgs/applications/audio/pulseaudio-dlna/default.nix

+                                                 faac
+                                                 flac
+                                                 sox
+                                                 vorbisTools ];


Maybe create arguments like mp3Support ? true, lame and then use ++ lib.optional mp3Support lame, so people can disable these optional dependencies.

dotlambda

I think pulseaudio-dlna has no tests, does it? If it doesn't, you should set doCheck = false and add a comment.

mogorman · 2018-02-21T09:00:16Z

@dotlambda made all the external apps that can be called optional but defaulted to true and bad include you pointed out. fixed formatting as per @FRidh request.

dotlambda · 2018-02-21T09:03:00Z

@mogorman Can please split the commit into two seperate ones for notify2 and pulseaudio-dlna?

@GrahamcOfBorg build python2.pkgs.notify2 python3.pkgs.notify2 pulseaudio-dlna

GrahamcOfBorg · 2018-02-21T09:03:21Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

Package ‘faac-1.29.9.2’ in /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/pkgs/development/libraries/faac/default.nix:32 has an unfree license (‘unfreeRedistributable’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-21T09:03:23Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘faac-1.29.9.2’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/libraries/faac/default.nix:32 has an unfree license (‘unfreeRedistributable’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

dotlambda · 2018-02-21T09:12:56Z

We should set faacSupport to false by default.

mogorman · 2018-02-21T09:17:43Z

@dotlambda 2 commits and changes made.

mogorman · 2018-02-21T09:18:18Z

@GrahamcOfBorg build python2.pkgs.notify2 python3.pkgs.notify2 pulseaudio-dlna

dotlambda · 2018-02-21T09:19:20Z

@GrahamcOfBorg build python2.pkgs.notify2 python3.pkgs.notify2 pulseaudio-dlna

GrahamcOfBorg · 2018-02-21T09:19:51Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01
gzipping man pages under /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/lib  /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/bin 
patching script interpreter paths in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01
checking for references to /tmp/nix-build-pulseaudio-dlna-2017-11-01.drv-0 in /nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01...
wrapping `/nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01/bin/pulseaudio-dlna'...
/nix/store/3zik190r9lxzvg2d022wfkajak3i4zd9-python2.7-notify2-0.3.1
/nix/store/30rxrg124ya5dylib8wncmix13rxvfqm-python3.6-notify2-0.3.1
/nix/store/g1hwq3mr4fdq7g5qicri20gb7hd1bxq8-pulseaudio-dlna-2017-11-01

dotlambda

I have not tested this, but it looks very nice.

GrahamcOfBorg · 2018-02-21T09:22:36Z

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01
gzipping man pages under /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/lib  /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/bin
patching script interpreter paths in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01
checking for references to /build in /nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01...
wrapping `/nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01/bin/pulseaudio-dlna'...
/nix/store/qshwzrbg28wsbym3hy4glkd7xs5v2kqj-python2.7-notify2-0.3.1
/nix/store/mnc59qrqx5mgb0fbr6w3k5bwjg30i669-python3.6-notify2-0.3.1
/nix/store/pypzyhi80q7bwm55c1bd3gib1c11jwdg-pulseaudio-dlna-2017-11-01

mogorman requested a review from FRidh as a code owner February 20, 2018 22:06

mogorman mentioned this pull request Feb 20, 2018

Feature Request: pulseaudio-dlna #35231

Closed

GrahamcOfBorg added the 6.topic: python label Feb 20, 2018

Mic92 reviewed Feb 20, 2018

View reviewed changes

dotlambda requested changes Feb 20, 2018

View reviewed changes

Mic92 reviewed Feb 20, 2018

View reviewed changes

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 20, 2018

mogorman force-pushed the pulseaudio-dlna branch from ab3cf89 to 44423c8 Compare February 21, 2018 04:14

mogorman force-pushed the pulseaudio-dlna branch from 44423c8 to ddda926 Compare February 21, 2018 04:19

FRidh reviewed Feb 21, 2018

View reviewed changes

dotlambda reviewed Feb 21, 2018

View reviewed changes

mogorman force-pushed the pulseaudio-dlna branch from ddda926 to 8cf5f8e Compare February 21, 2018 08:59

mogorman mentioned this pull request Feb 21, 2018

python-notify2: init at 0.3.1 #35262

Closed

8 tasks

mogorman added 2 commits February 21, 2018 04:14

python-notify2: init at 0.3.1

583ce2b

pulseaudio-dlna: init at 2017-11-01

2b3989f

mogorman force-pushed the pulseaudio-dlna branch from 8cf5f8e to 2b3989f Compare February 21, 2018 09:17

dotlambda approved these changes Feb 21, 2018

View reviewed changes

Mic92 merged commit a65221e into NixOS:master Feb 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pulseaudio-dlna #35245

pulseaudio-dlna #35245

mogorman commented Feb 20, 2018 •

edited

Mic92 Feb 20, 2018

Mic92 Feb 20, 2018

Mic92 Feb 20, 2018

dotlambda Feb 20, 2018

dotlambda Feb 20, 2018

mogorman Feb 20, 2018

Mic92 Feb 20, 2018 •

edited

dotlambda Feb 20, 2018

Mic92 Feb 20, 2018

mogorman Feb 20, 2018

Mic92 Feb 20, 2018

mogorman commented Feb 21, 2018

mogorman commented Feb 21, 2018 •

edited

FRidh Feb 21, 2018

dotlambda Feb 21, 2018

dotlambda Feb 21, 2018

dotlambda left a comment

mogorman commented Feb 21, 2018

dotlambda commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

dotlambda commented Feb 21, 2018

mogorman commented Feb 21, 2018

mogorman commented Feb 21, 2018

dotlambda commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

dotlambda left a comment

GrahamcOfBorg commented Feb 21, 2018


		doCheck = false; # Requires real X session to run tests

		src = pkgs.fetchurl {

pulseaudio-dlna #35245

pulseaudio-dlna #35245

Conversation

mogorman commented Feb 20, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 Feb 20, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mogorman commented Feb 21, 2018

mogorman commented Feb 21, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda left a comment

Choose a reason for hiding this comment

mogorman commented Feb 21, 2018

dotlambda commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

dotlambda commented Feb 21, 2018

mogorman commented Feb 21, 2018

mogorman commented Feb 21, 2018

dotlambda commented Feb 21, 2018

GrahamcOfBorg commented Feb 21, 2018

dotlambda left a comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Feb 21, 2018

mogorman commented Feb 20, 2018 •

edited

Mic92 Feb 20, 2018 •

edited

mogorman commented Feb 21, 2018 •

edited