stdenv: fix "grep: invalid range" #25501
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @lethalman and @dezgeg to be potential reviewers. |
|
Thanks, you got the intended meaning right. I assumed the ranges were more permissive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix the unnecessary error message, and the logic that the grep command is actually part of (presumably). @vcunat what's it actually meant to do? For now all it does is print "grep: invalid range" because the regex is actually malformed, so grep returns an error code and the if condition will never evaluate to true.
Things done
Not tested at all, because it causes a mass rebuild.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)