Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2755 -- open 127.0.0.1 instead of 0.0.0.0 in serve -b #2756

Merged
merged 1 commit into from May 12, 2017
Merged

Fix #2755 -- open 127.0.0.1 instead of 0.0.0.0 in serve -b #2756

merged 1 commit into from May 12, 2017

Conversation

Kwpolska
Copy link
Member

Open 127.0.0.1 when using nikola serve -b and default 0.0.0.0 hostname to avoid resolution issues — the site is still available on all interfaces.

@Kwpolska
Fix #2755 -- open 127.0.0.1 instead of 0.0.0.0 in serve -b
84ad63c 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.8.5 milestone May 11, 2017
@Kwpolska Kwpolska requested a review from ralsina May 11, 2017 18:40
@Kwpolska Kwpolska mentioned this pull request May 11, 2017
Closed
ralsina
ralsina approved these changes May 12, 2017
View reviewed changes
Copy link
Member

@ralsina ralsina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ralsina ralsina merged commit 3d77845 into master May 12, 2017
@ralsina ralsina deleted the fix-2755 branch May 12, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralsina ralsina ralsina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.8.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kwpolska @ralsina