darwin: trash 0.9.0 #25713
Merged
darwin: trash 0.9.0 #25713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
requested changes
May 12, 2017
| src = fetchFromGitHub { | ||
| owner = "ali-rantakari"; | ||
| repo = "trash"; | ||
| rev = "f68ad25a02e24cc58eb8ef9a493d6dc0122bcd8f"; |
There was a problem hiding this comment.
It would be better to use a release-tag instead of the revision. As there is no release-tag for 0.9.0 could you please ask the Author to create one?
| install -m 0444 trash.1 $out/share/man/man1 | ||
| ''; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
Please provide more metainformation.
|
@jbaum98 Are you still working on adding this package to Nix? |
|
I'm still waiting on the author to create a 0.9.0 release tag. |
|
If the author is that unresponsive we can also add it using the commit-hash. Could you rebase and add more meta-information (desription, license)? |
jbaum98
force-pushed
the
darwin-trash
branch
from
c0a0832
to
232ff39
Compare
|
I think I added the meta data you asked for, can we get this merged or is there more to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the
trashcommand for darwin.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)