Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fltk: 1.3.3 -> 1.3.4 #25708

Merged
merged 1 commit into from
May 19, 2017
Merged

fltk: 1.3.3 -> 1.3.4 #25708

merged 1 commit into from
May 19, 2017

Conversation

acowley
Copy link
Contributor

@acowley acowley commented May 11, 2017

This incidentally fixes the build on darwin.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This incidentally fixes the build on darwin.
@mention-bot
Copy link

@acowley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @edolstra and @vcunat to be potential reviewers.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, builds on NixOS.

@vcunat vcunat merged commit 0dbf5b0 into NixOS:master May 19, 2017
vcunat added a commit that referenced this pull request May 19, 2017
@acowley acowley deleted the fltk-1.3.4 branch October 9, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants