Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mawled: init at 20170517 #25858

Closed
wants to merge 2 commits into from
Closed

mawled: init at 20170517 #25858

wants to merge 2 commits into from

Conversation

amiloradovsky
Copy link

A minimalist window manager written in Dale.
Mawled is a basic X11 tiling window manager, inspired by XMonad, though with fewer features.

Motivation for this change

It has been requested.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

mawled: init at 20170517
fec4e87 
A minimalist window manager written in Dale.
Mawled is a basic X11 tiling window manager,
inspired by XMonad, though with fewer features.
@amiloradovsky amiloradovsky mentioned this pull request May 17, 2017
Closed
Mic92
Mic92 reviewed May 20, 2017
View reviewed changes
pkgs/applications/window-managers/mawled/default.nix Outdated
license = licenses.bsd3;
maintainers = with maintainers; [ amiloradovsky ];
platforms = with platforms; [ "i686-linux" "x86_64-linux" ];
# The Dale port is currently present only on these platforms
Copy link
Member

@Mic92 Mic92 May 20, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not have to make this explicit. hydra will not built this package, if the buildInputs are not available on the target platform.

platforms = platforms.linux;

should be good to go.

@Mic92
Copy link
Member

Mic92 commented May 20, 2017

How would I test this windowmanager?

$ mawled                                                                                                  
Error: serial 45, ec 522, rc 1080, mc 37431696, rid 246

@amiloradovsky
Copy link
Author

@Mic92 To be honest, I didn't actually tested it extensively, because it would require to disable my current DE (to execute ~/.xsession). I only

  • saw that error message(s) when tried to run it right from the DE -- that's no surprise
  • observed that pressing Alt+P, or any other reserved keybinding, makes it fail -- as expected
  • plus, people reported that it indeed works, on NixOS

But now, as I tried to actually use it as the WM (on another machine), i.e. via disabling a desktop manager and starting it from the terminal, I couldn't.

  • On an amd64 laptop it doesn't fail, doesn't show the errors, or any reaction at all...
  • In Qemu (i686), it crashed with segfailt

To recap, maybe I was too quick with opening the PR and it's still buggy as hell.
But I'd like to someone else confirm that it indeed behaves this way, and not just me forgetting to set some options. @jb55 ?

@matthewbauer
Copy link
Member

@GrahamcOfBorg build mawled

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: mawled

Partial log (click to expand)

Cannot nix-instantiate `mawled' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/lib/customisation.nix�[0m:113:35, called from �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/pkgs/top-level/all-packages.nix�[0m:1321:12:
while evaluating 'makeOverridable' at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/lib/customisation.nix�[0m:72:24, called from �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/pkgs/applications/window-managers/mawled/default.nix�[0m:1:1, called from �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/lib/customisation.nix�[0m:74:12:
while evaluating 'mkDerivation' at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/pkgs/stdenv/generic/make-derivation.nix�[0m:15:5, called from �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/pkgs/applications/window-managers/mawled/default.nix�[0m:5:4:
value is a string while a list was expected, at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/pkgs/stdenv/generic/make-derivation.nix�[0m:78:95

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: mawled

Partial log (click to expand)

Cannot nix-instantiate `mawled' because:
error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:1321:12:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/window-managers/mawled/default.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
while evaluating 'mkDerivation' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:15:5, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/window-managers/mawled/default.nix:5:4:
value is a string while a list was expected, at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:78:95

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mawled

Partial log (click to expand)

Cannot nix-instantiate `mawled' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/lib/customisation.nix�[0m:113:35, called from �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/top-level/all-packages.nix�[0m:1321:12:
while evaluating 'makeOverridable' at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/lib/customisation.nix�[0m:72:24, called from �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/applications/window-managers/mawled/default.nix�[0m:1:1, called from �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/lib/customisation.nix�[0m:74:12:
while evaluating 'mkDerivation' at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/stdenv/generic/make-derivation.nix�[0m:15:5, called from �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/applications/window-managers/mawled/default.nix�[0m:5:4:
value is a string while a list was expected, at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/stdenv/generic/make-derivation.nix�[0m:78:95

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @GrahamcOfBorg eval issue

@c0bw3b
Copy link
Contributor

c0bw3b commented May 18, 2019

Stalled

@c0bw3b c0bw3b closed this May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@amiloradovsky @Mic92 @matthewbauer @GrahamcOfBorg @c0bw3b @pSub