Set virtualisation.libvirtd.qemuOvmf to false as the OVMF closure-siz… #25855
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is too large for true to be the default.
|
@clefru, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rickynils, @edolstra and @fpletz to be potential reviewers. |
clefru
referenced
this pull request
May 17, 2017
bjornfor
pushed a commit
to bjornfor/nixpkgs
that referenced
this pull request
Jul 14, 2017
OVMF{,CODE,VARS}.fd are now available in a dedicated fd output, greatly
reducing the closure in the common case where only those files are used (a
few MBs versus several hundred MBs for the full OVMF).
Note: it's unclear why `dontPatchELF` is now necessary for the build to
pass (on my end, at any rate) but it doesn't make much sense to run this
fixup anyway,
Note: my reading of xen's INSTALL suggests that --with-system-ovmf should
point directly to the OVMF binary. As such, the previous invocation was
incorrect (it pointed to the root of the OVMF tree). In any case, I have
only built xen with `--with-system-ovmf`, I have not tested it.
Fixes NixOS#25854
Closes NixOS#25855
(cherry picked from commit 252dcd6)
[Bjørn: Conflicts in pkgs/applications/virtualization/xen/4.5.nix were
resolved by dropping the changes. In branch release-17.03
.../xen/4.5.nix doesn't use OVMF at all.]
8 tasks
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
OVMF{,CODE,VARS}.fd are now available in a dedicated fd output, greatly
reducing the closure in the common case where only those files are used (a
few MBs versus several hundred MBs for the full OVMF).
Note: it's unclear why `dontPatchELF` is now necessary for the build to
pass (on my end, at any rate) but it doesn't make much sense to run this
fixup anyway,
Note: my reading of xen's INSTALL suggests that --with-system-ovmf should
point directly to the OVMF binary. As such, the previous invocation was
incorrect (it pointed to the root of the OVMF tree). In any case, I have
only built xen with `--with-system-ovmf`, I have not tested it.
Fixes NixOS#25854
Closes NixOS#25855
(cherry picked from commit 252dcd6)
[Bjørn: Conflicts in pkgs/applications/virtualization/xen/4.5.nix were
resolved by dropping the changes. In branch release-17.03
.../xen/4.5.nix doesn't use OVMF at all.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e is too large for true to be the default.
Motivation for this change
df5d588#commitcomment-22166176 motivated this change.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)