Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-app-engine-go-sdk: init at 1.9.53 #25856

Merged
merged 4 commits into from
May 20, 2017
Merged

google-app-engine-go-sdk: init at 1.9.53 #25856

merged 4 commits into from
May 20, 2017

Conversation

lufia
Copy link
Contributor

@lufia lufia commented May 17, 2017

Motivation for this change

AppEngine SDK for Go is tools for developing, deploying, and managing apps in Google App Engine.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

version = version;
homepage = "https://cloud.google.com/appengine/docs/go/";
license = licenses.asl20;
platforms = with platforms; linux ++ darwin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so happy to maintain this package.
I will push new commits that add myself to maintainer list.

@Mic92 Mic92 merged commit a908f2a into NixOS:master May 20, 2017
@lufia
Copy link
Contributor Author

lufia commented May 24, 2017

hmm.. I installed this package on macOS after nix-channel --update.
install is succeed but goapp fails.

/Users/lufia/.nix-profile/bin/goapp: line 7: Convenience wrapper for starting a Go tool in the App Engine SDK.: command not found
ssh: Could not resolve hostname argparse: nodename nor servname provided, or not known
import: EOF
ssh: Could not resolve hostname os: nodename nor servname provided, or not known
import: EOF

goapp's code that raises this errors is:

#!/nix/store/37sk1sjzmky15nkxvyrw97sizx7fhlf2-python-2.7.13-env/bin/python2.7
#
# Copyright 2011 Google Inc. All rights reserved.
# Use of this source code is governed by the Apache 2.0
# license that can be found in the LICENSE file.

"""Convenience wrapper for starting a Go tool in the App Engine SDK."""

import argparse
import os
import sys

and /nix/store/37sk1sjzmky15nkxvyrw97sizx7fhlf2-python-2.7.13-env/bin/python2.7:

#! /nix/store/d0vj5xfr85716dz2k8xb6fhygxgllk3b-bash-4.4-p12/bin/bash -e
export PYTHONHOME="/nix/store/37sk1sjzmky15nkxvyrw97sizx7fhlf2-python-2.7.13-env"
exec "/nix/store/95ssabrarnq5w597y51c66zmvkd44xh0-python-2.7.13/bin/python2.7"  "${extraFlagsArray[@]}" "$@"

Perhaps, macOS's shebang requires to be binary.

$ cat wrap
#!/bin/bash -e

exec /usr/bin/python "$@"
$ cat hello
#!./wrap

if __name__ == '__main__':
	print "hello"
$ ./wrap hello
hello
$ ./hello
./hello: line 5: syntax error: unexpected end of file

I think this error is issue of python27.withPackages on macOS.
What do you think?

@Mic92
Copy link
Member

Mic92 commented May 31, 2017

@FRidh have you have heard of that issue before?

@FRidh
Copy link
Member

FRidh commented Jun 1, 2017

@lufia could very well be that we cannot use python.withPackages because of #11133.

@lufia lufia deleted the init-goappengine branch June 4, 2017 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants