solvespace: remove #25569
Closed
solvespace: remove #25569
+0
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whitequark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny, @globin and @bjornfor to be potential reviewers. |
thoughtpolice
requested changes
May 6, 2017
|
If you want to package something stable you want the last commit from the 2.x branch (now b1d87bf284b32e875c8edba592113e691ea10bcd), that includes the glibc fix as well. |
|
Sounds like @edef1c might have some work towards packaging a more recent version already. |
|
PR coming in a few minutes or so, just gonna test the version upgrade first and some minor changes to my build process. |
|
#25570 (that took a little longer than expected) |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm the current maintainer of solvespace. The version in nixpkgs is a very outdated port that should have never been merged by then-maintainer in the state that it was in, and is completely unusable for real-world work. Since I do not use NixOS, I cannot provide an updated recipe. However, on multiple occasions people ran this broken port with the expectation that it is usable software, and at least I'd like to prevent that.