nitrokey-app: 0.6.3 -> 1.1 #25565
Merged
nitrokey-app: 0.6.3 -> 1.1 #25565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated nitrokey-app and added a module for the udev rules. :) |
|
I think it would be useful to backport these changes to 17.03 because the nitrokey-app contains bugfixes and the module is completely new and independent. |
fpletz
added
the
9.needs: port to stable
The nitrokey-app is now fetched from git because a submodule is needed for compilation.
fpletz
removed
the
9.needs: port to stable
|
@fpletz, works like a charm. Thanks for fixing the udev-rules thingy 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nitrokey-app is now fetched from git because a submodule is needed
for compilation.
The udev rule is not picked up by the system. Maybe someone more knowledgeable can point me in the right direction how udev rules are handled by NixOS and how I can make sure that the udev rule of this package is considered by udev.
Motivation for this change
Update to latest upstream release
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)