intero-nix-shim: fix runtime dependencies #25571
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the inability to use projects’ |
|
@michalrus Yes, exactly. |
|
Thank you for the merge and backport! |
|
Thank you for this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@shlevy, in the initial PR, #24853, I forgot to include this part: https://github.com/michalrus/intero-nix-shim/blob/72677fb3a9f475f7f53715b18dc251ed83026410/default.nix#L13-L17
Partly due to “copying code” (having similar
default.nixin both repos) and forgetting to retest it, but that’s no excuse, I’m terribly sorry! 😿Do you think you could backport this to 17.03 as well? Without those two links, the version there is useless.
Things done
./result/bin/)