modules/hardware/all-firmware: add enableAllUnfreeFirmware #25567
Conversation
By introducing `broadcom-bt-firmware`, lots of machines stopped evaluating. We need a separate option for those firmwares.
| Turn on this option if you want to enable all the firmware shipped in linux-firmware. For unfree firmware, see <literal>hardware.enableAllUnfreeFirmware</literal>. | ||
| ''; | ||
| }; | ||
| hardware.enableAllUnfreeFirmware = mkOption { |
There was a problem hiding this comment.
Would it not been possible to just check if allowUnfree was true?
|
Reopen because there is a dispute about the fix in cc75ccb. |
|
@Mic92 I’d prefer for it to be explicit. By automatically including it when The more I think about it, the scarier it gets. I imagine removing some unfree package like |
|
But then the other option naming is also misleading |
That’s why I added a reference to the documentation. We should always handle unfree software explicitely and separately imho. |
|
All firmware files in this list are proprietary licensed. |
|
I made this pull request to solve both concerns: #25636 |
see also: https://github.com/winterheart/broadcom-bt-firmware/blob/master/LICENSE.broadcom_bcm20702 fixes #25567 (cherry picked from commit cc75ccb)
see also: https://github.com/winterheart/broadcom-bt-firmware/blob/master/LICENSE.broadcom_bcm20702 fixes NixOS#25567 (cherry picked from commit cc75ccb)
license was misinterpreted, it is now only conditionally in the all firmware list included, if `allowUnfree` is set. fixes NixOS#25567 (cherry picked from commit 192f8e7)
see also: https://github.com/winterheart/broadcom-bt-firmware/blob/master/LICENSE.broadcom_bcm20702 fixes NixOS#25567 (cherry picked from commit cc75ccb)
license was misinterpreted, it is now only conditionally in the all firmware list included, if `allowUnfree` is set. fixes NixOS#25567 (cherry picked from commit 192f8e7)
cc @Mic92