pythonPackages.piexif: init at 1.0.12 #25563
Merged
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
May 7, 2017
| # No .tar.gz source available at PyPI, only .zip source, so need to use | ||
| # fetchurl because fetchPypi doesn't support .zip. | ||
| src = fetchurl { | ||
| url = "mirror://pypi/packages/source/p/${pname}/${name}.zip"; |
There was a problem hiding this comment.
this url repeats a portion and thus downloading the file fails. The following would work:
"mirror://pypi/${builtins.substring 0 1 pname}/${pname}/${name}.zip";
There was a problem hiding this comment.
I made that change. Strange that I didn't get any download failures with that previous url.
|
Is this ok or does it need some fixes? |
FRidh
approved these changes
May 15, 2017
| version = "1.0.12"; | ||
|
|
||
| # pillow needed for unit tests | ||
| buildInputs = [ pillow ]; |
There was a problem hiding this comment.
While not used much yet, checkInputs is meant for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
piexifis a dependency for another package that I'm going to pull request soon.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)