Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solvespace: 2.0 -> 2.3 #25570

Merged
merged 2 commits into from
May 7, 2017
Merged

solvespace: 2.0 -> 2.3 #25570

merged 2 commits into from
May 7, 2017

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented May 6, 2017

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Remaining question: figure out if the version marker should include the commit hash
I'm not sure what the relevant nixpkgs conventions are, and SolveSpace doesn't have an official patch version number.
@whitequark (the maintainer) suggests including the git hash, although this doesn't provide ordering (does nix-env use version ordering?)

@edef1c edef1c mentioned this pull request May 6, 2017
Closed
@whitequark
Copy link

@whitequark (the maintainer) suggests including the git hash, although this doesn't provide ordering (does nix-env use version ordering?)

Doesn't have to be the git hash, I would just like to see the upstream version (2.3) clearly separated from anything packagers add. 2.3~1 or something like that is fine as the git hash is visible in the About dialog anyways.

@joachifm joachifm requested a review from the-kenny May 6, 2017 23:39
@ben0x539
Copy link
Contributor

ben0x539 commented May 6, 2017

don't we just put a date if we're shipping randon non-release revisions?

@thoughtpolice
Copy link
Member

Yes, a date marker would be fine, e.g. solvespace-2.3-20170506. In the very rare case there are two updates in a day you can do something else (-1 or whatever) but this is generally extremely rare.

Thanks for doing this!

@edef1c
Copy link
Member Author

edef1c commented May 6, 2017

Yes, a date marker would be fine, e.g. solvespace-2.3-20170506. In the very rare case there are two updates in a day you can do something else (-1 or whatever) but this is generally extremely rare.

Done.

Thanks for doing this!

❤️

@thoughtpolice thoughtpolice merged commit 1daa8ad into NixOS:master May 7, 2017
@edef1c edef1c deleted the solvespace-2.3 branch May 7, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edef1c @whitequark @ben0x539 @thoughtpolice