New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.setuptools_scm: 1.15.0 -> 1.15.6 #25581
Conversation
What is broken? |
Using this as a build input without also specifying git or mercurial.
…On 7 May 2017 at 19:59, Frederik Rietdijk ***@***.***> wrote:
The packages is broken as it stands.
What is broken?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25581 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAt6pSGN0WGTXPSPUMDspzr0YYWngmiSks5r3hSQgaJpZM4NTO6j>
.
--
Arthur Noel
arthur@0compute.net
+44 (0)7967 385514
|
Also add missing dependencies
This is still a problem - comment out the propagatedBuildInputs line and you will see test failures. Just rebased off master and updated from 15.5.5 to 15.5.6. |
How do you work with this package? |
Alright, then it indeed makes sense. Note that with the current infra we cannot add |
OK, I'll pull it out.
It might be nice to add a little comment explaining why - could you expand on the PYTHONPATH issue?
|
Sorry, don't bother, I see the problem now I think about it. |
The issue is that |
Thinking again, the I've just reviewed usage of |
Before I rebase again, are you happy in principle to merge this? |
84c6e6b is in, but it doesn't include the extra dependencies. Adding If you want to pursue this I suggest you ask @RonnyPfannschmidt if he is willing to introduce |
as far as i understood its only needed for the builds from scm repos its not needed to propagate |
Also add missing dependencies
Motivation for this change
The packages is broken as it stands.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)