Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.setuptools_scm: 1.15.0 -> 1.15.6 #25581

Closed
wants to merge 2 commits into from
Closed

pythonPackages.setuptools_scm: 1.15.0 -> 1.15.6 #25581

wants to merge 2 commits into from

Conversation

kingarrrt
Copy link
Contributor

Also add missing dependencies

Motivation for this change

The packages is broken as it stands.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@0arthur, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh
Copy link
Member

FRidh commented May 7, 2017

The packages is broken as it stands.

What is broken?

@kingarrrt
Copy link
Contributor Author

kingarrrt commented May 7, 2017 via email

@kingarrrt kingarrrt changed the title pythonPackages.setuptools_scm: 1.15.0 -> 1.15.5 pythonPackages.setuptools_scm: 1.15.0 -> 1.15.6 Jul 23, 2017
@kingarrrt
Copy link
Contributor Author

This is still a problem - comment out the propagatedBuildInputs line and you will see test failures.

Just rebased off master and updated from 15.5.5 to 15.5.6.

@FRidh
Copy link
Member

FRidh commented Jul 23, 2017

How do you work with this package?

@FRidh
Copy link
Member

FRidh commented Jul 23, 2017

Using this as a build input without also specifying git or mercurial.

Alright, then it indeed makes sense. Note that with the current infra we cannot add mercurial as propagatedBuildInput because it will mess up PYTHONPATH.

@kingarrrt
Copy link
Contributor Author

kingarrrt commented Jul 23, 2017 via email

@kingarrrt
Copy link
Contributor Author

Sorry, don't bother, I see the problem now I think about it.

@FRidh
Copy link
Member

FRidh commented Jul 23, 2017

The issue is that mercurial is implemented in Python. We still need to properly isolate Python applications like mercurial.

@kingarrrt
Copy link
Contributor Author

kingarrrt commented Jul 23, 2017

Thinking again, the propagatedBuildInputs get put on PYTHONPATH, but setuptools_scm should only ever be referenced in buildInputs, so this won't be an issue I think?

I've just reviewed usage of setuptools_scm and fixed the instances where it is referenced in propagatedBuildInputs.

@kingarrrt
Copy link
Contributor Author

Before I rebase again, are you happy in principle to merge this?

@FRidh FRidh self-assigned this Aug 19, 2017
@FRidh
Copy link
Member

FRidh commented Sep 13, 2017

84c6e6b is in, but it doesn't include the extra dependencies.

Adding git as propagatedBuildInput is fine, but adding mercurial is not due to the mentioned isolation.
Although, a good solution that will work is replacing in the following file calls to git with the full path, and the same in for mercurial in https://github.com/pypa/setuptools_scm/blob/v1.15.6/setuptools_scm/hg.py.

If you want to pursue this I suggest you ask @RonnyPfannschmidt if he is willing to introduce GIT = 'git' and HG = 'hg' so that we only need to replace those two lines with full paths.

@FRidh FRidh closed this Sep 13, 2017
@RonnyPfannschmidt
Copy link
Contributor

as far as i understood its only needed for the builds from scm repos its not needed to propagate
its not quite clear why build only requitrements need to propagate, just add them to PATH in the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants