docker-edge: 17.04 to 17.05 #25579
Merged
docker-edge: 17.04 to 17.05 #25579
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdemeester, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @NeQuissimus and @domenkozar to be potential reviewers. |
vdemeester
force-pushed
the
docker-edge-update-17.05
branch
from
0a4ebf1 to
bee6235
Compare
|
Any reason we would want to keep 17.04 around? |
|
@NeQuissimus not sure 😝 |
|
Taking a look at #24619, I don't think we need 17.04 for anything. It is being directly replaced by 17.05. |
pSub
added
the
8.has: package (update)
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
docker-edge-update-17.05
branch
from
bee6235 to
398f6ed
Compare
|
@NeQuissimus updated it but not sure why travis failed.. |
|
LGTM, works for me locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Demeester vincent@sbr.pm
Motivation for this change
Updating docker-edge to 17.05 now it's released.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)