Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: add a ghcDefault pkgset, pointing to current default #25070

Closed
wants to merge 1 commit into from
Closed

haskell: add a ghcDefault pkgset, pointing to current default #25070

wants to merge 1 commit into from

Conversation

Profpatsch
Copy link
Member

Slightly more semantic.

@mention-bot
Copy link

@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @Ericson2314 and @basvandijk to be potential reviewers.

jb55
jb55 reviewed Apr 21, 2017
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -5235,7 +5235,7 @@ with pkgs;

haskell = callPackage ./haskell-packages.nix { };

haskellPackages = haskell.packages.ghc802.override {
haskellPackages = haskell.packages.ghcDefault.override {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to have just ghc instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the whole point of this is that there was no „default“ packageset before. What you refer to is the compiler derivation (haskell.compiler.ghc).

@peti
Copy link
Member

peti commented Apr 21, 2017

IMHO, haskellPackages is the default package set in Nixpkgs. I don't see what we gain by introducing yet another name for it.

@Profpatsch
Copy link
Member Author

Yeah, I suppose we can leave it like that. Often there’s something like inherit (haskell.packages) ghc802, so I think it’s nice and consistent to have the default pointer in the same namespace as well, akin to ghcHEAD.

@peti
Copy link
Member

peti commented Apr 24, 2017

IMHO, people who inherit the ghc802 package set should probably inherit haskellPackages, really, unless they really want to hard-code a specific version.

@Profpatsch Profpatsch closed this Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Profpatsch @mention-bot @peti @jb55