libbsd: fixup on darwin #25069
Merged
libbsd: fixup on darwin #25069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my attempt to get libbsd workin on Darwin. It's kind of a mess right now with patches. Most of it are ugly hacks but at least it builds!
|
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @amiddelk, @peterhoeg and @aristidb to be potential reviewers. |
peterhoeg
reviewed
Apr 21, 2017
| sed -i '38i#undef strlcpy' include/bsd/string.h | ||
| sed -i '38i#undef strlcat' include/bsd/string.h | ||
| substituteInPlace src/setproctitle.c \ | ||
| --replace 'extern typeof(setproctitle_impl) setproctitle_stub __attribute__((weak, alias("setproctitle_impl")));' "" |
There was a problem hiding this comment.
Please turn this into a patch instead.
There was a problem hiding this comment.
ok I just combined everything into one patch. That way we won't change the hash for Linux systems.
|
Much nicer, thanks! 👍 |
|
@peterhoeg Do you remember what we changed to work around this? |
LnL7
approved these changes
Apr 21, 2017
|
@LnL7, we didn't. We simple avoided the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to get libbsd workin on Darwin. It's kind of a mess
right now with patches. Most of it are ugly hacks but at least it builds!
Should fix issue #23434
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)