@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @pSub and @edolstra to be potential reviewers.

@LnL7 got any advice for this? I could definitely split this up if it's too much. They're all good changes though and I hate clogging up the pr with 30+ minor fixes.

Tesseract, wordnet, anti word and libdvdread will probably have the same issue.

I only checked the packages with actual changes, I'll add everything to the list to make sure.
I think it's mainly personal preference, but I think bringing the licenses or platforms into scope is usually not really worth it since those are only used once or twice.

Can you fix these?

in job ‘pkgs.corn’:
value is null while a set was expected, at �[1m/nix/store/b3h0q1r7lja6a4c1yp9lfch15hjjsax2-git-export/lib/attrsets.nix�[0m:199:76

in job ‘pkgs.vte’:
value is null while a set was expected, at �[1m/nix/store/b3h0q1r7lja6a4c1yp9lfch15hjjsax2-git-export/lib/attrsets.nix�[0m:199:76

in job ‘pkgs.fbida.x86_64-darwin’:
Package ‘sane-backends-1.0.25’ in ‘/nix/store/b3h0q1r7lja6a4c1yp9lfch15hjjsax2-git-export/pkgs/applications/graphics/sane/backends/generic.nix:62’ is not supported on ‘x86_64-darwin’, refusing to evaluate.

Yeah I can get them. Interestingly, "miniupnpc" was already doing the same thing: https://github.com/ndowens/nixpkgs/blob/9d30abf7b201b6144883815fccf904e83555334b/pkgs/tools/networking/miniupnpc/default.nix#L21

I wonder if that was causing an error?

It's only a problem for expressions that use pkgs.darwin as an argument. That's why it usually works.

Ok so a rundown on those 3:

• fbida doesn't seem to ever have worked. I'm not sure why I had it in there. I just reverted it.
• pkgs.corn should be pkgs.cron, I messed up the name in the commit message, I can rework it if you want but I've been trying not to rebase unless absolutely necessary
• pkgs.vte should be pkgs.gnome3.vte

I can also squash the 2 reverted commits if you want but again I'm trying to avoid modifying commit hashes just in case you were working off of them.

Looks good now, you can rebase/squash.

ps. having a list of attribute paths for a batch pr like this would be pretty useful for me, I have some hydra configuration that I usually use to build a set of packages for a pr.

Ok everything looks good!