Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapnik: add optional PostgreSQL dependency for PostGIS input #25063

Closed
wants to merge 1 commit into from
Closed

mapnik: add optional PostgreSQL dependency for PostGIS input #25063

wants to merge 1 commit into from

Conversation

Hodapp87
Copy link
Contributor

@Hodapp87 Hodapp87 commented Apr 20, 2017 •
edited

Motivation for this change

Mapnik supports PostgreSQL & PostGIS, but only builds the PostGIS input plugin if PostgreSQL is available as a build-time dependency. This adds it, but makes it optional and disabled by default.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Hodapp87, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hrdinka, @FRidh and @knedlsepp to be potential reviewers.

@hrdinka
Copy link
Contributor

hrdinka commented Apr 20, 2017

Thanks for your contribution! I am for either renaming the option to enablePostgresql (this seems to be the most nix like of use…, with…, …Support) or just having a postgresql ? null option. That way one can easily pick the desired PostgreSQL version without overriding the derivation. Since picking a specific PostgreSQL version is quite common and we always keep ~5 versions around in nixpkgs I'm in favor of the later option.

@Hodapp87
Copy link
Contributor Author

That is a good point and something I had forgotten about. Is the updated commit what you meant?

@hrdinka hrdinka closed this in 5864baa Apr 21, 2017
hrdinka pushed a commit that referenced this pull request Apr 21, 2017
@Hodapp87 @hrdinka
mapnik: add optional PostgreSQL dependency
2af7c40 
Closes #25063.
@hrdinka
Copy link
Contributor

hrdinka commented Apr 21, 2017

Yes, that's what I meant :)

Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hodapp87 @mention-bot @hrdinka