Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imager (r-modules): add pkgs.x11, unmark imager/ForestTools as broken #25062

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Hodapp87
Copy link
Contributor

Motivation for this change

The R module imager is broken (the build complains of missing X11), and this change addresses that issue to allow the module to build. In the process, the R module ForestTools (which was marked as broken due to depending on imager) also now builds, so both were removed from brokenPackages.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc grahamc merged commit ce34caa into NixOS:master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants