lambda-mod-zsh-theme: 2015-12-15 -> 2017-04-05 #25492
Closed
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 5, 2017
| @@ -2,15 +2,15 @@ | |||
|
|
|||
| let | |||
| repo = "lambda-mod-zsh-theme"; | |||
| rev = "eceee68cf46bba9f7f42887c2128b48e8861e31b"; | |||
| rev = "c6445c79cbc73b85cc18871c216fb28ddc8b3d96"; | |||
| in stdenv.mkDerivation { | |||
| name = "${repo}-${rev}"; | |||
There was a problem hiding this comment.
I would like to see rather our lambda-mod-zsh-theme-unstable-year-month-day notation rather then commit hashes as version number.
There was a problem hiding this comment.
not sure if I got it right: you mean year-mongth-day of the latest commit included in our derivation? (same way as implemented in oh-my-zsh pkg?)
There was a problem hiding this comment.
yes. This is easier to reason about, then just a commit hash.
|
@Mic92 I changed that. Is it okay that I kept it in two commits (two seperate changes to the derivation, so it's IMHO way clearer in the history)? |
…45c79cbc73b85cc18871c216fb28ddc8b3d96
|
I rebased the commits onto latest master as my checkout of master seemed to be broken... |
Ma27
changed the title
|
updated for a better PR title... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A newer version of
lambda-mod-zsh-themecontains some fixes for several terminals:Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)