desktopManager service: Add wallpaper options #25496
Conversation
These options are used by `feh` when setting the wallpaper.
|
@TomSmeets, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ryantm, @nbp and @edolstra to be potential reviewers. |
| default = "scale"; | ||
| example = "fill"; | ||
| description = '' | ||
| Wallpaper image mode: |
There was a problem hiding this comment.
I do not think there is any documentation about the fact that ~/.background-image is used for the wallpaper image.
I think it would be good to make a follow-up patch to add this information as part of this description. What do you think?
There was a problem hiding this comment.
Yes, I agree.
It took me a while to figure out how to set the background image.
The background image path should probably be an option.
This would add the possibility of multiple images, one for each monitor. (with combineScreens disabled)
pSub
added
the
6.topic: nixos
| @@ -45,7 +73,7 @@ in | |||
| start = d.start | |||
| + optionalString (needBGCond d) '' | |||
| if [ -e $HOME/.background-image ]; then | |||
There was a problem hiding this comment.
shouldn't this check also be removed/edited?
There was a problem hiding this comment.
Why? The location didn't change.
|
Could this be merged? Being able to change the wallpaper path and having multiple images should be put in a different PR. |
|
@TomSmeets Sorry for the delay required for merging, and thanks for contributing these modifications! |
These changes won't affect desktop-managers that have set
bgSupporttotrue.Motivation for this change
I'd like to have my wallpaper stretch across multiple screens. (I'm not using a desktop manager)
Things done
This is why I added the
combineScreensoption.This makes feh use
--no-xineramasuch that the wallpaper is set in the root-window that stretches across multiple monitors.I also added a
modeoption for completeness, this provides more control on the image scale method.I set the default values such that existing configurations wont be affected.
Feedback
I'm not sure about the name of the
combineScreensoption.I'd love to receive feedback on this.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)(this is a module change and produces no binaries.)