3to2: init at 1.1.1 #25202
3to2: init at 1.1.1 #25202
Conversation
| version = "1.1.1"; | ||
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
I tried fetchPypi, but I it 404s for some reason, I think it has something to do with the package name starting with a number instead of a character.
There was a problem hiding this comment.
ah, no, they published a zip instead of a tar.gz. I still need to fix fetchPypi to try both since on PyPI you're allowed to upload either, but not both.
There was a problem hiding this comment.
@FRidh Or just allow to override the default from tar.gz to zip by the package author. This is how it is done in OpenEmbedded.
There was a problem hiding this comment.
@FRidh is there any update on adding support for zips for fetchPypi? I have another python package (fonttools) which only publishes zip files. If you're busy right now, I think I'll give it a try.
| ''; | ||
|
|
||
| # Test failing due to upstream issue (https://bitbucket.org/amentajo/lib3to2/issues/50/testsuite-fails-with-new-python-35) | ||
| doCheck = false; |
There was a problem hiding this comment.
and if you run it with other versions of Python?
There was a problem hiding this comment.
nix-build -A python33Packages.3to2 gives me error: hypothesis-3.7.0 not supported for interpreter python3.3m
There was a problem hiding this comment.
That's fine, you can ignore that.
There was a problem hiding this comment.
and how is it when you it with Python 2.x?
There was a problem hiding this comment.
nix-build -A python27Packages.3to2 fails tests exactly like the issue here: https://bitbucket.org/amentajo/lib3to2/issues/50/testsuite-fails-with-new-python-35
| meta = { | ||
| homepage = https://bitbucket.org/amentajo/lib3to2; | ||
| description = "Refactors valid 3.x syntax into valid 2.x syntax, if a syntactical conversion is possible"; | ||
| license = lib.licenses.asl20; |
There was a problem hiding this comment.
I'm pretty new to Nix, but if that's okay I have no problem with maintaining this.
There was a problem hiding this comment.
That's how we all begin :)
It's basically just about keeping track of updates and making sure the expression keeps working.
There was a problem hiding this comment.
Sounds great, added a commit adding myself to the maintainer list.
|
@FRidh there are new commits (and GitHub doesn't auto-notify of that) |
Motivation for this change
add 3to2
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)