Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xsession quoting #25198

Closed
wants to merge 8 commits into from
Closed

Xsession quoting #25198

wants to merge 8 commits into from

Conversation

nyarly
Copy link
Contributor

@nyarly nyarly commented Apr 25, 2017

Motivation for this change

SDDM still doesn't start correctly - session names like "i3 + xterm" get split in the "fix sddm" clause at the beginning of the session.

Things done

$1 -> "$1"

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Not every gem package uses pname, nor should it.
`usesGemspec` no longer required to trigger the "copy everything into
gemfile-and-lock" behavior. If the mainGem is referred to by path,
that's sufficient.
The bin stubs need to be built where there's access to /nix/store - so
it can't happen in a nix-shell run. Ergo, a shell.nix needs to be able
to signal to the build that all bins need to be built.
@mention-bot
Copy link

@nyarly, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @zimbatm and @manveru to be potential reviewers.

@nyarly nyarly closed this Apr 25, 2017
@nyarly
Copy link
Contributor Author

nyarly commented Apr 25, 2017

Git mess.

@nyarly nyarly deleted the xsession_quoting branch April 25, 2017 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants