lib: Consolidate tests into one meta job #25196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nbp, @Profpatsch and @MarcWeber to be potential reviewers. |
|
Make sure you rename it in make-tarball.nix too: nixpkgs/pkgs/top-level/make-tarball.nix Line 60 in 7a58679 |
|
Oh heh I didn't even see that. Maybe I'll just make the lib tests a sub job instead. |
|
Looks good to me, thanks! |
nbp
reviewed
May 5, 2017
| , # Strip most of attributes when evaluating to spare memory usage | ||
| scrubJobs ? true | ||
| }: | ||
| { pkgs ? import ((import ../../lib).cleanSource ../..) {} }: |
There was a problem hiding this comment.
You will have to update the list of attribute given when this expression is imported in pkgs/top-level/release.nix to make this evaluate correctly.
Ericson2314
force-pushed
the
recursive-platform-tests
branch
from
078fad1
to
4dbb408
Compare
Ericson2314
force-pushed
the
recursive-platform-tests
branch
from
4dbb408
to
296753f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@edolstra is this what you want?
Things done